[API-8] Resource Management#2135
Closed
mattmess1221 wants to merge 26 commits into
Closed
Conversation
I did most of this a few months ago. I don't remember all the specifics.
mattmess1221
force-pushed
the
feature/resources
branch
from
a319e8b to
a501fae
Compare
…to feature/resources
Zidane
reviewed
Jul 15, 2020
Zidane
reviewed
Jul 15, 2020
| /** | ||
| * Register event for client resources. | ||
| */ | ||
| interface Client extends RegisterReloadListener { |
Member
There was a problem hiding this comment.
Same as the above, a generic engine event.
If lifecycle, put it there along with the above.
Contributor
Author
There was a problem hiding this comment.
I wouldn't consider it a lifecycle event. It's just a specific event that does a specific task once at a specific time during init.
Zidane
reviewed
Jul 15, 2020
Zidane
reviewed
Jul 15, 2020
Zidane
reviewed
Jul 15, 2020
…to feature/resources
API: rename the register event method
mattmess1221
force-pushed
the
feature/resources
branch
2 times, most recently
from
ab2c194 to
de0c057
Compare
mattmess1221
force-pushed
the
feature/resources
branch
from
de0c057 to
2c45a73
Compare
Member
|
Closing in favor of https://github.com/SpongePowered/SpongeAPI/tree/feature/resources Thank you for all your work on this Killjoy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common
It's been nearly 3 years since I opened #1706, so here's starting fresh on a new branch with mostly new code.
The only thing I don't like is
PackDiscoverers. That part isn't critical to resources, so we can remove it and do it for another time if we're short on time.I'm also not sure if we need a separate event for registering reload listeners. We may be able to get away with having them be registered during ServerAboutToStartEvent. Input is appreciated.